[Bug 500926] Review Request: me-tv - GNOME desktop application for watching digital television
bugzilla at redhat.com
bugzilla at redhat.com
Fri May 15 10:14:46 UTC 2009
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=500926
--- Comment #2 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> 2009-05-15 06:14:44 EDT ---
Created an attachment (id=344112)
--> (https://bugzilla.redhat.com/attachment.cgi?id=344112)
Patch to compile
Compiles with the attached.
http://koji.fedoraproject.org/koji/taskinfo?taskID=1355776
http://koji.fedoraproject.org/koji/taskinfo?taskID=1355793
i.e.
----------------------------------------
#include <linux/types.h>
#include <sys/types.h>
----------------------------------------
fails but
----------------------------------------
#include <sys/types.h>
#include <linux/types.h>
----------------------------------------
succeeds. ref (from google):
http://lkml.indiana.edu/hypermail/linux/kernel/0902.0/01335.html
Some notes (note that I have not tested this software)
- suggest to add INSTALL="install -p" to 'make install' to
keep timestamps on installed files
- This package should own the directory %{_datadir}/%{name}/
- Would you check if the following build.log what you expect?
----------------------------------------
Optional engines support:
xine engine ................: yes
libvlc engine ..............: no
MPlayer engine .............: no
xine-lib engine ............: no
GStreamer library engine ...: no
----------------------------------------
It seems that "xine-lib engine" "GStreamer library engine"
can be enabled with some BRs in Fedora and some configure option,
however configure.ac says they are experimental so
I am not sure if you intentionally disabled this or not.
?? From src/xine_engine.cc, this software seems
to launch "xine" program :
----------------------------------------
49 void XineEngine::play(const Glib::ustring& mrl)
50 {
56 StringList argv;
57 argv.push_back("xine");
115 try
116 {
117 Glib::spawn_async_with_pipes("/tmp",
118 argv,
----------------------------------------
However xine binary is in xine package, which is in
rpmfusion-free. Does this software work even if
"xine" rpm is removed?
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the Fedora-package-review
mailing list