[Bug 497441] Review Request: mumble - Voice chat application

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=497441





--- Comment #64 from Igor Jurišković <juriskovic.igor at gmail.com>  2009-05-17 08:18:53 EDT ---
(In reply to comment #62)
> Created an attachment (id=344291)
 --> (https://bugzilla.redhat.com/attachment.cgi?id=344291) [details]
> Patch to compile on dist-f10-updates-candidate
> 
> For -10:
> 
> * BR
>   - BR: qt3-sqlite should not be needed. This uses Qt4, not
>     Qt3.
I uploaded wrong spec file. It was already removed at the time you wrote this.

> 
> * About mumble-server user directory
>   - Well, -d %{buildroot}%{_datadir}/%{name}/ is definitely wrong,
>     this directory should be used only when building this package.
>     I would suggest -d %{_localstatedir}/lib/mumble-server/
> 
Done.

> * Requires
>   - Needed Requires(pre) or so are still missing for murmur subpackage:
>    
> https://fedoraproject.org/wiki/Packaging/SysVInitScript#Initscripts_in_spec_file_scriptlets
> 
Done.

> * Build failure
>   - The attached patch will make this package compile on
>     F-11/F-10 (F-12 not checked)
>     http://koji.fedoraproject.org/koji/taskinfo?taskID=1358131
>     http://koji.fedoraproject.org/koji/taskinfo?taskID=1358127
> 
Included.

> * Devel files in main package
> ----------------------------------------------------------------------
> ln -s %{_libdir}/libmumble.so.%{version} %{buildroot}%{_libdir}/libmumble.so
> ----------------------------------------------------------------------
>   - I guess %_libdir/libmumble.so is not needed.
It is needed. Mumble will complain loudly if it cant find libmumble.so.
Thorvald said this few post back.

>     Note that rpmlint warns about this:
> ----------------------------------------------------------------------
> mumble.i586: W: devel-file-in-non-devel-package /usr/lib/libmumble.so
> ----------------------------------------------------------------------
> 
> * Service enabled by default
> ----------------------------------------------------------------------
> murmur.i586: W: service-default-enabled /etc/rc.d/init.d/murmur
> ----------------------------------------------------------------------
>   - Installing murmur package enables "murmur" service by default
>     on level 345:
> ----------------------------------------------------------------------
> # chkconfig --list murmur
> murmur   0:off 1:off 2:off 3:on 4:on 5:on 6:off
> ----------------------------------------------------------------------
>     These should be disabled by default.
>     In murmur init script, # Default-Start: item should have no
>     level.
Fixed.

> 
> * Init script fix
> ----------------------------------------------------------------------
> diff -uN mumble-1.1.8-9.fc9.src/murmur.init
> mumble-1.1.8-10.fc10.src/murmur.init
> --- mumble-1.1.8-9.fc9.src/murmur.init  2009-04-30 01:03:18.000000000 +0900
> +++ mumble-1.1.8-10.fc10.src/murmur.init        2009-05-15 08:32:48.000000000
> +0900
> @@ -52,7 +52,7 @@
>         RETVAL=$?
>         echo
>         if [ $RETVAL -eq 0 ]; then
> -               /bin/rm -f "$lockfile" "$pidfile" 2> /dev/null && success ||
> failure
> +               /bin/rm -f "$lockfile" "$pidfile" 2> /dev/null || failure
>         fi
>  }
> 
> ----------------------------------------------------------------------
>   - I guess " || failure" can also be removed.
> 
This was already changed at the time you wrote this. I accidently uploaded
wrong spec and srpm.

> * undefined non-weak symbols
> ----------------------------------------------------------------------
> mumble.i586: W: undefined-non-weak-symbol /usr/lib/libmumble.so.1.1.8
> glAttachShader
> mumble.i586: W: undefined-non-weak-symbol /usr/lib/libmumble.so.1.1.8 glEnable
> mumble.i586: W: undefined-non-weak-symbol /usr/lib/libmumble.so.1.1.8
> glTexCoordPointer
> ....
> (and so many)
> ----------------------------------------------------------------------
>   - libmumble.so has undefined non-weak symbols. As
>     this package does not provide -devel subpackage, currently this
>     can be ignored, however it is preferable that this issue
>     is fixed.
>     ! You can also check this issue by
>        $ ldd -r /usr/lib/libmumble.so.1 > /dev/null
>     This can be fixed by making libmumble.so linked against libGL.so.
> 
Thorvald answered this. I'm leaving this as is.

> * Permission
> ----------------------------------------------------------------------
> install -pD -m0664 man/murmurd.1 %{buildroot}%{_mandir}/man1/
> install -pD -m0664 man/mumble* %{buildroot}%{_mandir}/man1/
> ----------------------------------------------------------------------
>   - These should be 0644 permission
> 
Again, wrong spec file. :(

> (In reply to comment #60)
> > > * Installation directory
> > > ------------------------------------------------------------------
> > > install -pD -m0755 release/murmurd %{buildroot}%{_sbindir}/murmurd
> > > ln -s ../sbin/murmurd %{buildroot}%{_bindir}/%{name}-server
> > > ------------------------------------------------------------------
> > >   - Why is the same command has to be in two different directories
> > >     in the path with different names?
> > Less confusion. After years of mumble nobody told me murmur - everyone says
> > mumble-server.
>   - Well, What I wonder is that where murmurd is under /usr/sbin,
>     mumble-server is under /usr/bin. Why these directories are different?  
I moved symlink to sbin dir.

SPEC: http://78.46.84.75/fedora/mumble.spec
SRPM: http://78.46.84.75/fedora/mumble-1.1.8-11.fc10.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.