[Bug 490354] Review Request: emacs-elib - The Emacs Lisp Library
bugzilla at redhat.com
bugzilla at redhat.com
Sun May 17 19:33:38 UTC 2009
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=490354
Jochen Schmitt <jochen at herr-schmitt.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |jochen at herr-schmitt.de
Flag| |fedora-review?
--- Comment #1 from Jochen Schmitt <jochen at herr-schmitt.de> 2009-05-17 15:33:36 EDT ---
Good:
+ Package name matches naming guildlines
+ Buildroot will be cleaned at the beginning of %clean and %install
* Specification of the Buildroot is ok.
Bad:
- Basename of the SPEC file doesn't machtes package name
- URL doesn't shows on proper project homepage
- Source doesn't contains full qualified URL
- Please change BuildArchitecures into BuildArch:
- Source are not in separe el subpackage
(/Packaging/Emacs#Packaging_of_source_elisp_files)
- Specification of the installation destination on fullfill Emace
Packaging guulldline
(/Packaging/Emacs#GNU_Emacs)
- Package doesn't contains correct Changelog
you have to specified version-release on it
Your package seems to need a lot of love. I want to suggest that you should
read the packaging guildlines and the guildlines for emacs packages carefully.
If you can demonstrate in your next approach, that you have understand this
guildlines, I may be willing to sponsor you.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the Fedora-package-review
mailing list