[Bug 499306] Review Request: jconv - Jack Convolution Engine

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=499306


Mattias Ellert <mattias.ellert at fysast.uu.se> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |mattias.ellert at fysast.uu.se
               Flag|                            |fedora-review+

Bug 499306 depends on bug 498862, which changed state.

Bug 498862 Summary: Review Request: clthreads - POSIX threads C++ access library
https://bugzilla.redhat.com/show_bug.cgi?id=498862

           What    |Old Value                   |New Value
----------------------------------------------------------------------------
             Status|ON_QA                       |CLOSED
         Resolution|                            |NEXTRELEASE



--- Comment #2 from Mattias Ellert <mattias.ellert at fysast.uu.se>  2009-05-19 13:58:13 EDT ---
Fedora review jconv-0.8.1-1.fc10.src.rpm 2009-05-19

* OK
! needs attention

* rpmlint output is OK:

  [ellert at ellert jconv]$ rpmlint *.rpm jconv.spec 
  3 packages and 1 specfiles checked; 0 errors, 0 warnings.

* Package is named according to guidlines

* Specfile is named after the package

* The package license tag (GPLv2+) is Fedora approved

* The package license tag matches the license statements in the sources

* The license file (COPYING) is installed as %doc

* The specfile is written in legible English

* Sources matches upstream, and are the latest version:

  7c194e36ecc59fd443ad08405cb40d73  SRPM/jconv-0.8.1.tar.bz2
  7c194e36ecc59fd443ad08405cb40d73  jconv-0.8.1.tar.bz2
  a33ec6a97fac039400f7674f3bde4ca9  SRPM/jconv-reverbs.tar.bz2
  a33ec6a97fac039400f7674f3bde4ca9  jconv-reverbs.tar.bz2

* Package compiles in mock (Fedora 10)

* Build requires are sane and reflect the libraries that are linked to
  during the build

* Package owns the directories it creates

* No duplicate files

* Permissions are sane and %files has %defattr

* %clean clears buildroot

* Macros are used consistently

* Package does not own other's directories

* %install clears buildroot

* Installed filenames are valid UTF8


Package approved.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.