[Bug 497639] Review Request: gmixer - Just a simple audio mixer

bugzilla at redhat.com bugzilla at redhat.com
Thu May 21 13:12:32 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=497639





--- Comment #10 from leigh scott <leigh123linux at googlemail.com>  2009-05-21 09:12:31 EDT ---
(In reply to comment #9)
> Two more things:
> 
> ------------------------------------------------------
> in %files section change:
> %{python_sitelib}/gmixer-1.0-py2.6.egg-info
> to:
> %{python_sitelib}/gmixer-1.0-py2.5.egg-info
> 
> Because thats the right name of the file.
> ------------------------------------------------------
> remove %doc in files section. You have no documentation so its useless.
> ------------------------------------------------------
> 
> 
> 
> I have to go now for few hours. When I get back I'll make full review.  

Ok, I have made the recommended changes.


>%{python_sitelib}/gmixer-1.0-py2.6.egg-info

is correct for F11 & F12, changing it to 

> %{python_sitelib}/gmixer-1.0-py2.5.egg-info

would be wrong as well, so I changed it to 

%{python_sitelib}/gmixer-1.0-py?.?.egg-info

This will enable it to build with python 2.5 or 2.6 


Spec: http://leigh123linux.fedorapeople.org/review/gmixer/5/gmixer.spec


SRPM:
http://leigh123linux.fedorapeople.org/review/gmixer/5/gmixer-1.3-4.fc11.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list