[Bug 490061] Review Request: awesfx - Utility programs for AWE32/Emu10k1

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=490061





--- Comment #6 from Guido Grazioli <guido.grazioli at gmail.com>  2009-05-28 12:03:40 EDT ---
(In reply to comment #5)
> Issues:
> - Package does not match the naming guidelines, Correct is version 0.5.1
> release 1%{?dist} see
> http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Post-Release_packages

Sorry i dont understand this one; i read the guidelines and it seems to be
correct to version the package 0.5.1c, as it is the third bugfix release under
version 0.5.1

> 
> - change License tag to GPLv2+, take a look at the source
> 
> - You are not owning %{buildroot}/etc/alsa.d, and AFAIK that dir is not created
> by another package ether
> 
> - this wont work %dir %{_datadir}/soundfonts/*.bnk
> 
> - add INSTALL ="install -p" to make install to preserve timestamps of the
> soundbank files
> 
> - I suggest to use install rather then cp so you can always be sure permissions
> are correct.  

ok


rpmlint is now silent; latest files here:
http://guidograzioli.fedorapeople.org/packages/awesfx/awesfx.spec
http://guidograzioli.fedorapeople.org/packages/awesfx/awesfx-0.5.1c-2.fc9.src.rpm

cheers

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.