[Bug 503148] Review Request: kmess - a msn messenger for kde

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=503148


Jussi Lehtola <jussilehtola at fedoraproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |jussilehtola at fedoraproject.
                   |                            |org
         AssignedTo|nobody at fedoraproject.org    |jussilehtola at fedoraproject.
                   |                            |org
               Flag|                            |fedora-review?




--- Comment #1 from Jussi Lehtola <jussilehtola at fedoraproject.org>  2009-05-29 16:09:40 EDT ---
Some initial notes:


- Is the target platform stuff really necessary? Doesn't a simple
 %{cmake_kde4}
 make VERBOSE=1 %{?_smp_mflags}
do the job?

- You don't need to use
 %setup -q -n %{name}-%{version}
a simple
 %setup -q
will do.


- You probably don't need to
 mkdir %{buildroot}
as this should be automatically done by make install.

- You must install the desktop file as per
http://fedoraproject.org/wiki/Packaging/Guidelines#Desktop_files

- You must handle locale files as per
http://fedoraproject.org/wiki/Packaging/Guidelines#Handling_Locale_Files

- You need to
 Requires: hicolor-icon-theme
for dir ownership.

- You need to update icon cache as per
https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#Icon_Cache

- Explicit requires of libraries (qca2) is not allowed
http://fedoraproject.org/wiki/Packaging/Guidelines#Explicit_Requires

- %{_kde4_appsdir}/kmess/icons/hicolor/*/apps/gnomemeeting.png doesn't look
correct.

- You're missing the source URL, ref
http://fedoraproject.org/wiki/Packaging/SourceURL

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.