[Bug 498721] Review Request: php-ezc-Webdav - eZ Components Webdav

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=498721


Remi Collet <fedora at famillecollet.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fedora at famillecollet.com
         AssignedTo|nobody at fedoraproject.org    |fedora at famillecollet.com
               Flag|                            |fedora-review+




--- Comment #2 from Remi Collet <fedora at famillecollet.com>  2009-05-30 02:55:12 EDT ---
REVIEW:

+ rpmlint is ok
php-ezc-Webdav.src: I: checking
php-ezc-Webdav.noarch: I: checking
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
+ package name ok
+ spec file name ok
+ package meet the PHP Guidelines (new update)
+ License ok : BSD
+ License is upstream 
+ spec in english and legible
+ license file in sources is provided
+ sources match the upstream sources
b97a4d88771171bbeba466837be97e4c  Webdav-1.1.tgz
+ Source URL ok
+ build  on F11.x86_64
+ BuildRequires (php-pear >= 1:1.4.9-1.2, php-channel(components.ez.no)) ok
+ no locale
+ no .so
+ own all directories that it creates
+ no duplicate file
+ %defattr ok
+ %clean section
~ use macros consistently
+ contain code
+ small documentation not required to run
+ no devel
+ no pkgconfig
+ no sub-package
+ no GUI
+ don't own files or directories already owned by other packages
+ %install start with rm -rf 
+ valid UTF-8
+ build in mock (fedora-rawhide-x86_64)
+ no test suite
+ scriptlets ok
~ Final Requires ok
/usr/bin/pear  
php-common >= 5.2.1
php-pear(components.ez.no/Base) >= 1.6
php-xml  
+ Final Provides ok
php-pear(components.ez.no/Webdav) = 1.1
php-ezc-Webdav = 1.1-1.fc8

Notes:

Should use %global rather than %define

As reported by pci, this need mime_magic.
ezcWebdavFileBackend::getMimeType, can use fileinfo (first) or mime_magic
(second, but not available) or a DAV property or a default value.

So, Should requires Fileinfo extension.

"grep -r hasExtensionSupport /usr/share/pear/ezc/Webdav" doesn't report other
optional extension

No blocker, so

========
APPROVED
========

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.