[Bug 502920] Review Request: polkit-gnome - PolicyKit integration for the GNOME desktop

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=502920





--- Comment #12 from Christoph Wickert <fedora at christoph-wickert.de>  2009-05-31 06:37:49 EDT ---
(In reply to comment #11)
> - "BuildRequires: gnome-doc-utils" seems wrong to me, AFAIKS only gtkdoc-check
> from gtk-doc is needed.
> 
> Well, thats what you think. Had you tried to build in mock, like I did, you'd
> see that gnome-doc-utils is needed for the build to succeed.
> 
> - This is the successor of PolicyKit-gnome, but the Provides and Obsoletes for
> it are missing.
> 
> You want us to break rawhide until all the porting is done ? Really ?

No, but I want this to be in the spec, even if it's commented out, so the
reviewer could verify it is correct.

> - HACKING and TODO are missing from %doc, possibly also NEWS, but this one is
> very outdated  
> 
> Both of these are not useful at all in a non-devel package, I'd say.  

As long as we have no devel package they should be in the base package I think.

The main problem I see is that you rewrote the spec and based your review on
the rewrite. This renders the review pretty useless because nobody will realize
his own errors.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.