[Bug 532203] Review Reques: jgraph - Java-based Diagram Component and Editor

bugzilla at redhat.com bugzilla at redhat.com
Sun Nov 1 12:29:14 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=532203





--- Comment #3 from Lubomir Rintel <lkundrak at v3.sk>  2009-11-01 07:29:13 EDT ---
(In reply to comment #1)
> Replying to some comments from previous (deadreview) bug (Bug 472793)
> 
> Notes
> ===
> $ rpmlint jgraph.spec
> jgraph.spec:68: W: non-standard-group Development/Documentation
> 
> I believe this can be ignored, as it matches the template spec files in the
> java packaging guidelines. 

Might be. I replaced this with Documentation, just to be on safe side.

> >This is pretty much irrelevant to this package review.
> 
> I believe it may be relevant, as otherwise your -debuginfo package is broken.
> There are workarounds shown in both that bug (bug 472292) and in bug 191014.
> Please fix this.

Ah, sorry, you're right. I thought this was common to all Java packages, not
this package's fault. Addressed in new version.

> I think this package is almost done. Please post a spec fixing the above and I
> will review the package.
> ===
> 
> Random comments:
> ===
> >Umm, no that's definitely not needed for review, feel free to do that yourself
> >(technically, one architecture-release combination is needed and there's no
> >clear reason why would they fail, nor indication that packager intends to
> >create branches for these).
> 
> When doing your CVS request, please create a branch for F-11 - its is
> definitely not EOL, and is hence *supported*. F-10 is no longer required as it
> will very soon be EOL.

I do not need this anywhere < Fedora 13. Common practice is that if anyone else
needs this, he maintains it there. Therefore, if you need the package in F-12,
F-11 or even F-10, feel free to maintain it there yourself (once it's in), but
the maintenance burden is on your shoulders :) That means -- it's waste of
bandwidth and builders cpu cycles from my point of view, since I don't care :)

> > > Fully standards-compliant (What standard? ISO 9001? Why do I (user) care?)
> 
> > Interoperability?
> 
> Apologies for the following rant, feel free to skip it as the current
> description is good :)

I won't pretend I knew what ISO 9001 is :)

New package:

SPEC: http://v3.sk/~lkundrak/SPECS/jgraph.spec
SRPM: http://v3.sk/~lkundrak/SRPMS/jgraph-5.12.2.1-3.fc12.src.rpm
scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1780977

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list