[Bug 464141] Review Request: perl-Text-Trac - Perl extension for formatting text with Trac Wiki Style

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=464141


Timon <timosha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|needinfo?(timosha at gmail.com |
                   |)                           |




--- Comment #11 from Timon <timosha at gmail.com>  2009-11-03 03:20:36 EDT ---
(In reply to comment #8)
> 1]
> please bump everytime you provide new version of package release number and
> post links to new version in your reply
I have some problems with public web server. So I attach spec and SRPM.

> 2]
> %defattr(0644,root,root,0755)
> do you have any reason why not to use %defatter(-,root,root,-) ?
> https://fedoraproject.org/wiki/Packaging/Guidelines#File_Permissions
fixed 

> 3] cp in makefile is without -p switch, write patch that cp in Makefile will be
> performed with -p switch (sed during prep will be good enough)
> https://fedoraproject.org/wiki/Packaging/Guidelines#Timestamps
This is CPAN Package and Makefile generates using Makefile.PL perl script. I
can sed in %build section, but I don't think this is good idea. I looked into
other SRPM made from CPAN, but didn't find any resolutions of this problem. 

> 4]
> BuildRequires:  perl(Test::Pod::Coverage)
> BuildRequires:  perl(Test::Pod)
fixed

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.