[Bug 526876] Review Request: php-pecl-gmagick - Provides a wrapper to the GraphicsMagick library
bugzilla at redhat.com
bugzilla at redhat.com
Tue Nov 3 10:29:31 UTC 2009
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=526876
--- Comment #6 from Pavel Alexeev (aka Pahan-Hubbitus) <pahan at hubbitus.info> 2009-11-03 05:29:30 EDT ---
(In reply to comment #5)
> * Consistent use of macros
> - if using the %{__make} style macros then you need to be consistent, i.e use
> %{__install}, %{__rm}, %{__chmod} etc
%{__make} replaced to plain make.
Additionally %{?_smp_mflags} added.
> * Make the spec more eligible by formatting it correctly, at the moment the
> directives at the top are not aligned.
Top directives are ALIGNED with tabs by width 5 spaces. Please read my first
post.
http://hubbitus.net.ru/rpm/Fedora11/php-pecl-gmagick/php-pecl-gmagick-1.0.2b1-3.fc11.src.rpm
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the Fedora-package-review
mailing list