[Bug 516517] Review Request: globus-gridftp-server - Globus Toolkit - Globus GridFTP Server

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=516517


Steve Traylen <steve.traylen at cern.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |steve.traylen at cern.ch
               Flag|                            |fedora-review?




--- Comment #1 from Steve Traylen <steve.traylen at cern.ch>  2009-11-03 18:24:14 EDT ---
Review of globus-gridftp-server

Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=1786926

almost: rpmlint
$ rpmlint SPECS/globus-gridftp-server.spec \
    RPMS/x86_64/globus-gridftp-server-* \
    SRPMS/globus-gridftp-server-3.17-1.fc12.src.rpm 

globus-gridftp-server.x86_64: W: shared-lib-calls-exit
/usr/lib64/libglobus_gridftp_server.so.0.3.17 exit at GLIBC_2.2.5
globus-gridftp-server.x86_64: W: no-documentation
globus-gridftp-server-devel.x86_64: W: no-documentation
globus-gridftp-server-progs.x86_64: W: no-documentation
5 packages and 1 specfiles checked; 0 errors, 4 warnings.

yes: package named as per-globus.
yes: spec file correct.
yes: globus guidelines good.
yes: ASL 2.0 in .spec
yes: contents is also ASL 2.0
yes: GLOBUS_LICEENSE include.
yes: english .spec
yes: legible spec.
yes: upstream matches.

$ md5sum globus_gridftp_server-3.17.tar.gz
~/rpmbuild/SOURCES/globus_gridftp_server-3.17.tar.gz 
4f1b25af2672acd1f9eaee3e6a6be40e  globus_gridftp_server-3.17.tar.gz
4f1b25af2672acd1f9eaee3e6a6be40e 
/home/steve/rpmbuild/SOURCES/globus_gridftp_server-3.17.tar.gz


yes: compiles , see koji above.
yes: builds on all archs.
yes: builds on all archs.
yes: build dependencies sane.
yes: no locales anyway.
yes: ldoconfig called correctly.
yes: no statics.
yes: owns all directories.
yes: no duplicate files.
yes: all %defattr.
yes: %clean is cleaned.
yes: contains code.
yes: no large docs anyway.
yes: doc not needed.
yes: headers are in devel.
yes: pkgconfig required.
yes: devel does require base explicitly.
yes: no gui.
yes: owns all files or directories or pulls them in.
yes: %install is cleaned.
yes: utf8.

At last a package that actually does something useful :-)

Can you submit a bug upstream on 0 exit from lib and I'll approve.

Steve

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.