[Bug 516280] Review Request: perl-Config-Model-CursesUI - Curses interface to edit config data

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=516280


Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

Bug 516280 depends on bug 516271, which changed state.

Bug 516271 Summary: Review Request: perl-Curses-UI - Curses based OO user interface framework
https://bugzilla.redhat.com/show_bug.cgi?id=516271

           What    |Old Value                   |New Value
----------------------------------------------------------------------------
             Status|ON_QA                       |CLOSED
         Resolution|                            |ERRATA



--- Comment #8 from Parag AN(पराग) <panemade at gmail.com>  2009-11-05 00:50:39 EDT ---
Review:
+ package builds in mock (rawhide i686).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1789156
+ rpmlint output for SRPM and for RPM.
perl-Config-Model-CursesUI.noarch: W: invalid-license LGPL
==> Fix this
+ source files match upstream url(sha1sum)
d79c4a2ad400efa725806f3344495b86bcda9294  Config-Model-CursesUI-1.103.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=1, Tests=3,  1 wallclock secs ( 0.02 usr  0.01 sys +  0.24 cusr  0.02
csys =  0.29 CPU)
+ Package  perl-Config-Model-CursesUI-1.103-2.fc12.noarch=>
Provides: perl(Config::Model::CursesUI) = 1.103
Requires: perl(Carp) perl(Config::Model::Exception)
perl(Config::Model::ObjTreeScanner) perl(Curses::UI) perl(Exception::Class)
perl(Exporter) perl(strict) perl(vars) perl(warnings)
+ Not a GUI application

Suggestions:
1) Correct license is LGPLv2+ so change it before you import this package in
cvs.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.