[Bug 532057] Review Request: eclipse-jgit - Eclipse JGit

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=532057





--- Comment #6 from Alexander Kurtakov <akurtako at redhat.com>  2009-11-05 10:49:10 EDT ---
(In reply to comment #5)
> - naming fine
> X please fix the release to follow:
> 
> http://fedoraproject.org/wiki/Packaging/NamingGuidelines#PreReleasePackages
> 
> Peter is right that there should be a 1. before the "git..."
> 
Fixed.

> - licensing fine (EDL is BSD)
> - macros fine
> - locations good
> - %files fine
> - simplicity = good :)
> 
> X rpmlint output clean except directory permission error:
> 
> 0 packages and 1 specfiles checked; 0 errors, 0 warnings.
> 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
> eclipse-jgit.noarch: E: non-standard-dir-perm
> /usr/share/eclipse/dropins/jgit/eclipse/features/org.eclipse.jgit_0.6.0.200911031418
> 0775

I don't see this error when build locally

> A standard directory should have permission set to 0755. If you get this
> message, it means that you have wrong directory permissions in some dirs
> included in your package.
> 
> 1 packages and 0 specfiles checked; 1 errors, 0 warnings.  

New sources:
Spec URL: http://akurtakov.fedorapeople.org/eclipse-jgit.spec
SRPM URL:
http://akurtakov.fedorapeople.org/eclipse-jgit-0.6.0-0.git20091029.1.fc11.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.