[Bug 529283] Review Request: fontbox - Java library for working with PDF fonts

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=529283


Orcan 'oget' Ogetbil <oget.fedora at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |oget.fedora at gmail.com
         AssignedTo|nobody at fedoraproject.org    |oget.fedora at gmail.com
               Flag|                            |fedora-review+




--- Comment #1 from Orcan 'oget' Ogetbil <oget.fedora at gmail.com>  2009-11-07 15:43:34 EDT ---
I reviewed this. There are very minor issues that can be fixed before you
import:

* rpmlint says:
   W: non-standard-group Development Documentation
      This should be just "Documentation"
   W: libdir-macro-in-noarch-package (main package) %attr(-,root,root)
%{_libdir}/gcj/%{name}
      rpmlint is wrong. This one can be ignored.

- Patches should be explained and be submitted to upstream. Since this is a
pure Fedora specific patch we can ignore the upstream part.

! %if %{with_gcj}
  %attr(-,root,root) %{_libdir}/gcj/%{name}
  %endif

Here %attr(-,root,root) is not needed. I know this is in the guidelines but
they have to be corrected. (I proposed this a while ago but things are going a
little slow with updating these guidelines.)


------------------------------------------
This package (fontbox) is APPROVED by oget
------------------------------------------

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.