[Bug 530756] Review Request: circuit_macros - A set of macros for drawing high-quality line diagram

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=530756


Chitlesh GOORAH <chitlesh at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |chitlesh at gmail.com
         AssignedTo|nobody at fedoraproject.org    |chitlesh at gmail.com
               Flag|                            |fedora-review?




--- Comment #7 from Chitlesh GOORAH <chitlesh at gmail.com>  2009-11-08 05:39:03 EDT ---
#001: Requires

README states : 

REQUIRED SOFTWARE:
Preferred setup:
  m4, dpic (see below), TeX or LaTeX, PSTricks, dvips

Update your Requires accordingly

#002: Requires of Sub package - examples

Requires:      %{name}
should rather be 
Requires:     %{name} = %{version}-%{release}

#003: I think you are forgetting *.m4 found in the -doc directory.

#004: 2 directories for documentation ?

The main package has /usr/share/doc/circuit_macros-6.61/ for its %doc

The sub package has /usr/share/doc/circuit_macros/examples for its %doc

I prefer that there is only ONE directory for ALL documentation. It is simply
because while giving the user more examples cases, we should not drown the user
into confusion.

#005: You are missing the subdirectories found in the examples directory.
These should found their way to your -examples subpackage

#006: the *.tex from the examples should also be added to the -examples
subpackage. It is an example (and source) how to use those symbols into one's
latex document.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.