[Bug 533738] Review Request: bwa - Burrows-Wheeler Alignment Tool

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=533738


Scott Collier <boodle11 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |boodle11 at gmail.com




--- Comment #1 from Scott Collier <boodle11 at gmail.com>  2009-11-08 15:57:01 EDT ---
Hi Albert,

I'm not a sponsor, but I do have some suggestions:

1. Package did not build for me by default:

http://boodle.fedorapeople.org/RPMS/bwa_install_error.out

2. Source0: should point to URL, please see:

http://fedoraproject.org/wiki/Packaging/SourceURL

3. You can add this to your make:
CFLAGS="$RPM_OPT_FLAGS"

Then it will compile.

4. For the %install:

You can use install instead of cp, for example:
install -Dp -m0755 bwa %{buildroot}/%{_bindir}/

and change the permissions to whatever you'd like.

After these changes, rpmlint is clean:

$ rpmlint bwa.spec 
0 packages and 1 specfiles checked; 0 errors, 0 warnings.

$ rpmlint bwa.spec 
0 packages and 1 specfiles checked; 0 errors, 0 warnings.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.