[Bug 479527] Review Request: synfigstudio - Vector-based 2D animation studio

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=479527


Luya Tshimbalanga <luya at fedoraproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review?




--- Comment #1 from Luya Tshimbalanga <luya at fedoraproject.org>  2009-11-12 23:26:43 EDT ---
Here is review:

+ $ rpmlint Downloads/synfigstudio-0.61.09-1.el5.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

+ spec and source file matches the package name and comply with Package Naming
Guideline

+ License is GPLv2

+ Spec file is legible and written in American English

+ Package is a GUI application. desktop-file-utils requirement is provided and
.desktop is used as required by Packaging Guideline

+ $ md5sum rpmbuild/SOURCES/synfigstudio-0.61.09.tar.gz
Downloads/synfigstudio-0.61.09.tar.gz 
09dac04ce8b6b8ac0ff15fde4b041eed  rpmbuild/SOURCES/synfigstudio-0.61.09.tar.gz
09dac04ce8b6b8ac0ff15fde4b041eed  Downloads/synfigstudio-0.61.09.tar.gz

Downloads path is taken from upstream thus match the source package from src
file.

+ Usage of Macros are consistent in spec file

+ Source URL matches upstream and is fully functional

+ All .la are excluded from the package

+ The package owns directory and files it creates

+ Package is succesfully compiled and build with synfig devel package from
#531773. No sure if I should let pass synfigstudio because of missing
synfig-devel otherwise it can be accepted once synfig package is available on
repository.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.