[Bug 537084] Review Request: libmpc - C library for multiple precision complex arithmetic

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=537084


Ralf Corsepius <rc040203 at freenet.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review?




--- Comment #7 from Ralf Corsepius <rc040203 at freenet.de>  2009-11-13 01:28:21 EDT ---
(In reply to comment #6)
Much better, now ;)

Launching formal review:

Mostly OK, except:

* (MUSTFIX) /usr/include/mpc.h includes "mpfr.h" and "gmp.h", i.e. there is a
hard dependency between *-devel and mpfr-devel+gmp-devel
=> *-devel must Require: mpfr-devel gmp-devel

* (SHOULD) What is the reason for you to explicitly pass
--entry ... while installing the infos?
Except of cases, when the infos are broken, such a step should not be necessary
and thus be avoided.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.