[Bug 537585] Review Request: picocontainer - Dependency-injection container

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=537585





--- Comment #3 from Michal Ingeli <mi at v3.sk>  2009-11-14 21:22:28 EDT ---
(In reply to comment #2)
> 1.) BuildRoot, please fix it up according to guidelines.
> 
> BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-root

Looking at [1], buildroot seems to be rather valid and according to guidelines.

> 2.) No useless comments please
> 
> #setup -q -c -n %{name}-%{version}

Right, removed that one.

> 3.) Please don't do the jpackage javadoc magic:
> 
> ln -s %{name}-%{version} $RPM_BUILD_ROOT%{_javadocdir}/%{name}
> %ghost %doc %{_javadocdir}/%{name}  

Removed.

Also decided to removed -target 1.5 and -encoding param for javac as it is may
be better not force thing. And forgotten -verbose.

Spec URL: http://v3.sk/~xyzz/rpm/intellij-idea/picocontainer.spec
SRPM URL: http://v3.sk/~xyzz/rpm/intellij-idea/picocontainer-1.3-6.fc11.src.rpm

[1] http://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.