[Bug 527986] Review Request: taoframework - Multimedia bindings for Mono

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=527986





--- Comment #9 from Christian Krause <chkr at plauener.de>  2009-11-15 11:47:33 EDT ---
I've reviewed the new package - here are the some minor remaining issues:

- very minor issue: please add a comment in the %build section that parallel
build doesn't work

- thanks for adding the dependencies - most of them are OK, but for some of
them there are some inconsistencies between the *.config files and the provided
libraries:

I've seen that sometimes the required libraries are not included in Fedora but
only in one of the rpmfusion repositories. I'm a little bit unsure, whether it
is OK if a Fedora package requires an rpmfusion package, but on the other hand
IMHO there is more harm done if the user tries to use the taoframework
subpackage (without having the required native library installed) and the mono
runtime will just abort and give backtraces. So I would vote for adding the
requirements even if they are not in the official Fedora repository.
Sure, the package can't be installed then on a Fedora-only system, but it
doesn't matter because it wouldn't work anyway. ;-)

Additionally sometimes the major version of the libraries differ between the
required ones in the config files and the ones provided in the system. Is there
any possibility to test, whether a respective binding works?

- ffmpeg
the config files maps the following libraries:
        <dllentry os="linux" dll="libavcodec.so.1d" />
        <dllentry os="linux" dll="libavformat.so.1d" />
        <dllentry os="linux" dll="libavutil.so.1d" />
I haven't found them in any fedora or rpmfusion package. Probably the name is
mis-spelled?

- lua
the config file claims to use the following shared object
        <dllentry os="linux" dll="liblua5.1.so.0" />
however, lua in Fedora provides only:
/usr/lib/liblua-5.1.so
Please adjust the config file.

- ode
the config files maps the following library:
        <dllentry os="linux" dll="libode.so.0debian1" />
but in it is named in Fedora:
/usr/lib/libode.so.1
Please adjust the config file.

- physfs:
        <dllentry os="linux" dll="libphysfs-1.0.so.0" />
vs.
/usr/lib/libphysfs-1.0.so.1
Please adjust the config file.

- SDL:
        <dllentry os="linux" dll="libsmpeg-0.4.so.0" />
requires smpeg-libs from rpmfusion-free, I suggest to add smpeg-libs to the
requirements

mismatch in SDL_gfx:
       <dllentry os="linux" dll="libSDL_gfx.so.4" />
vs
 /usr/lib/libSDL_gfx.so.0
Please adjust the config file.

- cg:
requires /usr/lib/Cg.so and libCgGL.so which are provided by
libCg in rpmfusion-nonfree

- glfw:
        <dllentry os="linux" dll=""libglfw.so" />
should be better
        <dllentry os="linux" dll="libglfw.so.2.6" />

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.