[Bug 524283] Review Request: plee-the-bear - 2D platform game

bugzilla at redhat.com bugzilla at redhat.com
Tue Nov 17 12:26:51 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=524283





--- Comment #3 from Lubomir Rintel <lkundrak at v3.sk>  2009-11-17 07:25:29 EDT ---
(In reply to comment #2)
> FIX - MUST: $ rpmlint /var/lib/mock/fedora-12-ppc/result/*
[ ... lots of unverisoned sonames in /usr/lib/libbear_*.so ... ]

These are OK. They are used exclusively by the binaries shipped with the game,
we don't even provide a -devel subpackage.

> FIX - MUST: License field in spec file doesn't matches the actual license:
> License:        GPLv2+ and CC-BY-SA

Good catch. Fixed.

> FIX - SHOULD: Scriptlets are used, those scriptlets must be sane.
> update icon cache scriplet is missing
> https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache

Fixed.

> FIX - Timestamps
> INSTALL="install -p"
> SOURCE0 original = 03 Sep 2009 02:32:34 CEST
> SOURCE0 package = 16 Sep 2009 00:01 CEST  

Done

New package:

SPEC: http://v3.sk/~lkundrak/SPECS/plee-the-bear.spec
SRPM: http://v3.sk/~lkundrak/SRPMS/plee-the-bear-0.4.1-2.fc11.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list