[Bug 538046] Review Request: spacewalk-certs-tools - Spacewalk SSL Key/Cert Tool

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=538046


Jochen Schmitt <jochen at herr-schmitt.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |jochen at herr-schmitt.de
               Flag|                            |fedora-review?




--- Comment #1 from Jochen Schmitt <jochen at herr-schmitt.de>  2009-11-17 15:46:38 EDT ---
Good:
+ Name of the package fullfill naming guidelines
+ Basename of the SPEC file matches with package name
+ Text in package is written in English
+ URL shows on proper homepage of the project
+ Should downloading upstream tarball via spectool -g
+ Package sources matches with upstream tar ball
+ License tag exlaim GPLv2 as a valis OSS license
+ Copyrigh notes on the head of source files matches
  with license statement of the license tag
(md5sum: 8060d39e6f3ea5984cdd643405bfebb1)
+ Package will build as noarch
+ Package has no subpackages
+ Package has proper definition of the BuildRoot
+ Local build works fine
+ BuildRoot will be cleaned at beginning of %clean and %install
+ Rpmlint is silent on source rpm
+ Rpmlint is silent on binary rpm
+ Locan install/uninstall works fine
+ Scratch build works fine on koji
+ %files stanza has no duplicates entries
+ Ammount of documentation is small, so we need
  no doc subpackages
+ Package has proper Changelog

Bad:
- Package doesn't contains a verbatin copy ot the license
  text (No blocker, but please contact upstream to include 
  one into the upstream package)
- Please use %global instead of %define
- Please use
    %global rhnroot %{_datadir}/rhn
  instead of
    %define rhnroot %{_prefix}/share/rhn
- We prefer %defattr(-,root,root,-)
- question: Who should ownd %{rhnroot} and
  %{rhnroot}/certs

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.