[Bug 538558] Review Request: kde-partitionmanager - KDE Partition Manager

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=538558





--- Comment #2 from Thomas Janssen <thomasj at fedoraproject.org>  2009-11-18 18:01:15 EDT ---
Thanks for doing the review.

(In reply to comment #1)

> Bad
> - Rpmlint complaints on binary package:
>   $ rpmlint kde-partitionmanager-1.0.0-1.fc11.x86_64.rpm
>   kde-partitionmanager.x86_64: E: invalid-soname
> /usr/lib64/libpartitionmanagerprivate.so libpartitionmanagerprivate.so
>   1 packages and 0 specfiles checked; 1 errors, 0 warnings.
>   Please contact upstream author to fix it.

I asked about that rpmlint output in #fedora-kde before i upped this review
request and got answers from rdieter and Kevin_Kofler that it's only a private
lib.
"It's perfectly normal for a KCM to be an unversioned .so, it's a plugin, not a
library, it gets dlopened. Nothing else will use it."
Any further thoughts on that?

> - Please mof the desktop-file-validate command to the %install stanza

Moved to %install

> - qt4-devel is not required as a BR, because kdelibs4-devel requires
>   qt4-devel  

Removed the BR


-- 
Fedora Bugzappers volunteer triage team
https://fedoraproject.org/wiki/BugZappers

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.