[Bug 538303] Review Request: rubygem-minitest - Small and fast replacement for ruby's huge and slow test/unit

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=538303





--- Comment #6 from Matthew Kent <mkent at magoazul.com>  2009-11-21 15:30:53 EDT ---
(In reply to comment #4)
> (In reply to comment #3)
> > > * Requires/BuildRequires
> > >   - Would you check if "Requires: rubygem(hoe)" is really needed?  
> >
> > Seems to be. The Rakefile uses hoe's lib/hoe/test.rb to provide the following
> > tasks:
> 
> However
> - In my opinition, to begin with Rakefile is usually somewhat similar
>   with Makefiles on autotool based tarball. So I usually put Rakefile
>   to -doc subpackage as I don't think people usually need Rakefile.
> 
> - As you know usually I always request to execute "rake test" in
>   rpmbuild (i.e. executing test should be done by _us_, like "make check").
>   If the dependency for "rake test" is needed, perhaps we have to
>   add "Requires: rubygem(rake)" (not BuildRequires) for binary gem-based
>   rpm, which I think is not desired.  

Oh sorry! I missed the Requires line for hoe and was looking at the
BuildRequires. Your right, the Requires for hoe isn't necessary. 

And putting the Rakefile in doc seems like a good idea.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.