[Bug 524992] Review Request: toppler - platform game

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=524992


David Timms <dtimms at iinet.net.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dtimms at iinet.net.au




--- Comment #9 from David Timms <dtimms at iinet.net.au>  2009-11-22 05:07:39 EDT ---
(In reply to comment #7)
> Full review (md5sum, license, spec file readability, etc.) done, the package
> looks good. I have only one remark. I'm not completely happy with how the
> highscore file is handled.
Just wanted to run a possible solution past you guys:
- each high score gets added to individual gamename-highscores-username.file
- game loads and merges all gamename-highscores-usernames.file
- sorts by high score, throws away any record below the h.s.table count.
- even if you haven't made the top table, it would be nice for your best score
to date to be displayed ;-)

I'm still not sure about where the game, run as a user, would store such a
file, possible a local .config/games/highscore file.
It would make sense that while joeb is playing, only the -joeb.file needs to be
writable by joeb (which works out, since it is in his directory).

But when jenc is playing, and the game is playing as jenc, to display the hs
table, the game needs to read all -username.file from all available home dirs;
that would require all users on the machine to be able to read other user's
high scores.

That might also trouble selinux.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.