[Bug 537451] Review Request: eclipse-emf-query - Specify and execute queries against EMF models

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=537451





--- Comment #3 from Mat Booth <fedora at matbooth.co.uk>  2009-11-24 06:42:10 EDT ---
(In reply to comment #1)
> * Package name and version are in accordance with packaging guidelines
> * SPEC file clean, legible and well-commented
> * License tag correct, license packaged as %doc
> * Filelist okay, for directories it uses and does now it depends on packages
> that provide them
> * Provides/Require list ok
> (mock build did not finish yet)
> 
> Objections:
> 
> 1.) Why do you check stuff out from CVS?
> 

This should be satisfactorily answered in bug #536683.

> 2.) Please don't pretty-format the Description, please use complete sentences.
> It does not always look well in package management front-ends.
> 
> 3.) RPMLint:
> 
> eclipse-emf-query.noarch: W: spurious-executable-perm
> /usr/share/doc/eclipse-emf-query-1.3.0/epl-v10.html
> The file is installed with executable permissions, but was identified as one
> that probably should not be executable.  Verify if the executable bits are
> desired, and remove if not.
> 
> eclipse-emf-query.noarch: W: spurious-executable-perm
> /usr/share/doc/eclipse-emf-query-1.3.0/notice.html
> The file is installed with executable permissions, but was identified as one
> that probably should not be executable.  Verify if the executable bits are
> desired, and remove if not.  

Done and done:

Spec URL: http://mbooth.fedorapeople.org/reviews/eclipse-emf-query.spec
SRPM URL:
http://mbooth.fedorapeople.org/reviews/eclipse-emf-query-1.3.0-2.fc10.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.