[Bug 508922] Review Request: system-config-selinux - GUI Code for system-config-selinux, polgen, and lockdown

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=508922





--- Comment #31 from Jussi Lehtola <jussi.lehtola at iki.fi>  2009-11-24 08:14:47 EDT ---
OK, I had a look at the spec file and came up with a few comments:

- instead of
 %dir %{_datadir}/system-config-selinux
 %{_datadir}/system-config-selinux/*
I would suggest using just
 %{_datadir}/system-config-selinux/
which does the same thing. (Same for the python_sitelib).

- Isn't there a Python egg...?

- I think you should Requires: dbus for dir ownership.

- Dir issue:
$ yum provides /usr/share/PolicyKit/policy/
results in no matches.
$ yum provides /usr/share/PolicyKit/
results in no matches. Filed bug #540888.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.