[Bug 529374] Review Request: ethos - Plugin framework for GLib

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=529374


Peter Robinson <pbrobinson at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED




--- Comment #2 from Peter Robinson <pbrobinson at gmail.com>  2009-11-24 12:37:26 EDT ---

> NOT OKAY - MUST: Named according to the Package Naming Guidelines
> the name of the package should be libethos, because it is a lib
> Group:          System Environment/Libraries
> NOT OKAY - MUST: Spec file name matches the base package %{name} 
> should be libethos

Actually ethos is fine because that's what the upstream name of the project is.

> NOT OKAY - MUST: Fedora approved license and meets the Licensing Guidelines
> License is LGPLv2+, and this is a good license
> NOT OKAY - MUST: License field in spec file matches the actual license
> License:        LGPLv2+

The README file states that it uses the LGPLv2.1 license and doesn't state 'or
later versions' hence the reason the + wasn't added. I believe this is correct.

> NOT OKAY - MUST: Sources match the upstream source by MD5
> your command "git clone git://git.dronelabs.com/ethos" give me a newer
> revision, you should add the command to co this version. then the md5sum od DL
> and pacakge should match.

There's now a new official upstream 0.2.2 release. I was using the git snapshot
as it was required by emerillon. I will update the package shortly. Also its
the second 'git archive' command below the clone that actually gives you the
correct version of the tar ball if you use the defined variables in the spec
file so you can get the exact same version.

> # git clone git://git.dronelabs.com/ethos
> you have girrevision: 9d3aae9 as source0 you should add the command how to co
> (explicit) this version and not the newest one.
> If i tried this I would get a newer one co

You can. See this is the spec
# Tarfile created using git
# git clone git://git.dronelabs.com/ethos
# git archive --format=tar --prefix=%{name}-%{version}/ %{git_version} | bzip2
> %{name}-%{version}.tar.bz2
%define git_version 9d3aae9
%define tarfile %{name}-%{version}.tar.bz2

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.