[Bug 541004] Review Request: pkcs11-dump - Small utility for querying PKCS#11 modules

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=541004


Antti Andreimann <antti.andreimann at mail.ee> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |antti.andreimann at mail.ee
         AssignedTo|nobody at fedoraproject.org    |antti.andreimann at mail.ee
               Flag|                            |fedora-review+




--- Comment #2 from Antti Andreimann <antti.andreimann at mail.ee>  2009-11-24 14:45:21 EDT ---
Reviewed according to
http://fedoraproject.org/wiki/Packaging/ReviewGuidelines

Legend:
OK  - no problems
N/A - requirement not applicable for this package
ERR - requirement not met
ATN - requirement met, but needs attention
DNR - item was not checked by the reviewer (usually because it's optional)

Required items:
[ OK  ] no rpmlint errors or warnings
[ OK  ] correct package naming
[ OK  ] correct spec naming
[ OK  ] acceptable license
[ OK  ] correct license field
[ OK  ] license file in %doc
[ OK  ] correct spec language
[ OK  ] acceptable spec legibility
[ OK  ] sources match upstream
        96b8eb05037d3033638f54ae46b1bbb3  pkcs11-dump-0.3.3.tar.bz2
[ OK  ] builds on primary architectures (i686, x86_64)
[ N/A ] correct ExcludeArchs
[ OK  ] correct BuildRequires
[ N/A ] properly handled locales
[ N/A ] ldconfig in %post and %postun
[ OK  ] no system libraries
[ OK  ] no relocation
[ OK  ] correct directory ownership
[ OK  ] no duplicates in %files section
[ OK  ] permissions set correctly
[ OK  ] %clean section removes build root
[ OK  ] consistent macro usage
[ OK  ] contains only code (no standalone content)
[ OK  ] large documentation in -doc sub-package
[ OK  ] files in %doc not required to function
[ N/A ] header files in -devel sub-package
[ N/A ] static libraries in -static sub-package
[ N/A ] proper use of Requires: pkgconfig
[ N/A ] .so files in -devel sub-package
[ N/A ] fully versioned dependency in -devel package
[ N/A ] no libtool archives (.la files) in package
[ N/A ] %{name}.desktop file(s) installed for GUI applications
[ OK  ] does not claim ownership to other package directories
[ OK  ] %install section removes buildroot
[ OK  ] filenames in UTF-8

Optional items:
[ N/A ] ask upstream to include license text in separate file
[ N/A ] description and summary available in different languages
[ OK  ] package builds in mock
[ DNR ] package builds on all supported architectures
[ DNR ] package functions as described
[ N/A ] rpm scriptlets are sane
[ N/A ] all sub-packages have fully versioned dependency
[ N/A ] .pc files in -devel sub-package
[ OK  ] no file dependencies outside of "bin" directories

Additional items by the reviewer:
[ OK  ] verbose build logs, compiler flags are visible
[ OK  ] RPM_OPT_FLAGS are honoured
[ OK  ] original timestamps are preserved

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.