[Bug 537563] Review Request: mingw32-plib - Fedora mingw set of portable game related libraries

bugzilla at redhat.com bugzilla at redhat.com
Wed Nov 25 11:59:39 UTC 2009 

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=537563


Peter Lemenkov <lemenkov at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review?




--- Comment #5 from Peter Lemenkov <lemenkov at gmail.com>  2009-11-25 06:59:37 EDT ---
Notes:

* Why not to drop static libraries completely?

Other things looks sane.

+ rpmlint is not silent, but all these messages are just false positive and may
be ignored.

[petro at Workplace Desktop]$ rpmlint mingw32-plib-1.8.5-0.fc12.noarch.rpm 
mingw32-plib.noarch: E: arch-independent-package-contains-binary-or-object
/usr/i686-pc-mingw32/sys-root/mingw/lib/libplibsg.dll.a
mingw32-plib.noarch: E: arch-independent-package-contains-binary-or-object
/usr/i686-pc-mingw32/sys-root/mingw/lib/libplibsl.dll.a
mingw32-plib.noarch: E: arch-independent-package-contains-binary-or-object
/usr/i686-pc-mingw32/sys-root/mingw/lib/libplibpu.dll.a
mingw32-plib.noarch: E: arch-independent-package-contains-binary-or-object
/usr/i686-pc-mingw32/sys-root/mingw/lib/libplibjs.dll.a
mingw32-plib.noarch: E: arch-independent-package-contains-binary-or-object
/usr/i686-pc-mingw32/sys-root/mingw/lib/libplibfnt.dll.a
mingw32-plib.noarch: E: arch-independent-package-contains-binary-or-object
/usr/i686-pc-mingw32/sys-root/mingw/lib/libplibssg.dll.a
mingw32-plib.noarch: E: arch-independent-package-contains-binary-or-object
/usr/i686-pc-mingw32/sys-root/mingw/lib/libplibul.dll.a
mingw32-plib.noarch: E: arch-independent-package-contains-binary-or-object
/usr/i686-pc-mingw32/sys-root/mingw/lib/libplibssgaux.dll.a
mingw32-plib.noarch: E: arch-independent-package-contains-binary-or-object
/usr/i686-pc-mingw32/sys-root/mingw/lib/libplibpuaux.dll.a
mingw32-plib.noarch: E: arch-independent-package-contains-binary-or-object
/usr/i686-pc-mingw32/sys-root/mingw/lib/libplibpw.dll.a
mingw32-plib.noarch: E: arch-independent-package-contains-binary-or-object
/usr/i686-pc-mingw32/sys-root/mingw/lib/libplibsm.dll.a
mingw32-plib.noarch: E: arch-independent-package-contains-binary-or-object
/usr/i686-pc-mingw32/sys-root/mingw/lib/libplibnet.dll.a
mingw32-plib.noarch: E: arch-independent-package-contains-binary-or-object
/usr/i686-pc-mingw32/sys-root/mingw/lib/libplibpsl.dll.a
mingw32-plib.noarch: W: devel-file-in-non-devel-package
/usr/i686-pc-mingw32/sys-root/mingw/lib/libplibsg.dll.a
mingw32-plib.noarch: W: spurious-executable-perm
/usr/i686-pc-mingw32/sys-root/mingw/lib/libplibsg.dll.a
mingw32-plib.noarch: W: devel-file-in-non-devel-package
/usr/i686-pc-mingw32/sys-root/mingw/lib/libplibsl.dll.a
mingw32-plib.noarch: W: spurious-executable-perm
/usr/i686-pc-mingw32/sys-root/mingw/lib/libplibsl.dll.a
mingw32-plib.noarch: W: devel-file-in-non-devel-package
/usr/i686-pc-mingw32/sys-root/mingw/include/plib/netSocket.h
mingw32-plib.noarch: W: devel-file-in-non-devel-package
/usr/i686-pc-mingw32/sys-root/mingw/include/plib/ssg.h
mingw32-plib.noarch: W: devel-file-in-non-devel-package
/usr/i686-pc-mingw32/sys-root/mingw/include/plib/sg.h
mingw32-plib.noarch: W: devel-file-in-non-devel-package
/usr/i686-pc-mingw32/sys-root/mingw/include/plib/pu.h
mingw32-plib.noarch: W: devel-file-in-non-devel-package
/usr/i686-pc-mingw32/sys-root/mingw/include/plib/puAux.h
mingw32-plib.noarch: W: devel-file-in-non-devel-package
/usr/i686-pc-mingw32/sys-root/mingw/include/plib/puGLUT.h
mingw32-plib.noarch: W: devel-file-in-non-devel-package
/usr/i686-pc-mingw32/sys-root/mingw/include/plib/net.h
mingw32-plib.noarch: W: devel-file-in-non-devel-package
/usr/i686-pc-mingw32/sys-root/mingw/include/plib/psl.h
mingw32-plib.noarch: W: devel-file-in-non-devel-package
/usr/i686-pc-mingw32/sys-root/mingw/include/plib/sm.h
mingw32-plib.noarch: W: devel-file-in-non-devel-package
/usr/i686-pc-mingw32/sys-root/mingw/include/plib/ssgAux.h
mingw32-plib.noarch: W: devel-file-in-non-devel-package
/usr/i686-pc-mingw32/sys-root/mingw/include/plib/puNative.h
mingw32-plib.noarch: W: devel-file-in-non-devel-package
/usr/i686-pc-mingw32/sys-root/mingw/lib/libplibpu.dll.a
mingw32-plib.noarch: W: spurious-executable-perm
/usr/i686-pc-mingw32/sys-root/mingw/lib/libplibpu.dll.a
mingw32-plib.noarch: W: devel-file-in-non-devel-package
/usr/i686-pc-mingw32/sys-root/mingw/lib/libplibjs.dll.a
mingw32-plib.noarch: W: spurious-executable-perm
/usr/i686-pc-mingw32/sys-root/mingw/lib/libplibjs.dll.a
mingw32-plib.noarch: W: devel-file-in-non-devel-package
/usr/i686-pc-mingw32/sys-root/mingw/include/plib/ssgconf.h
mingw32-plib.noarch: W: devel-file-in-non-devel-package
/usr/i686-pc-mingw32/sys-root/mingw/include/plib/pw.h
mingw32-plib.noarch: W: devel-file-in-non-devel-package
/usr/i686-pc-mingw32/sys-root/mingw/include/plib/ssgaWaveSystem.h
mingw32-plib.noarch: W: devel-file-in-non-devel-package
/usr/i686-pc-mingw32/sys-root/mingw/include/plib/ssgaBillboards.h
mingw32-plib.noarch: W: devel-file-in-non-devel-package
/usr/i686-pc-mingw32/sys-root/mingw/lib/libplibfnt.dll.a
mingw32-plib.noarch: W: spurious-executable-perm
/usr/i686-pc-mingw32/sys-root/mingw/lib/libplibfnt.dll.a
mingw32-plib.noarch: W: devel-file-in-non-devel-package
/usr/i686-pc-mingw32/sys-root/mingw/include/plib/netMonitor.h
mingw32-plib.noarch: W: devel-file-in-non-devel-package
/usr/i686-pc-mingw32/sys-root/mingw/include/plib/puAuxLocal.h
mingw32-plib.noarch: W: devel-file-in-non-devel-package
/usr/i686-pc-mingw32/sys-root/mingw/include/plib/puFLTK.h
mingw32-plib.noarch: W: devel-file-in-non-devel-package
/usr/i686-pc-mingw32/sys-root/mingw/include/plib/ssgKeyFlier.h
mingw32-plib.noarch: W: devel-file-in-non-devel-package
/usr/i686-pc-mingw32/sys-root/mingw/include/plib/netMessage.h
mingw32-plib.noarch: W: devel-file-in-non-devel-package
/usr/i686-pc-mingw32/sys-root/mingw/include/plib/netBuffer.h
mingw32-plib.noarch: W: devel-file-in-non-devel-package
/usr/i686-pc-mingw32/sys-root/mingw/include/plib/fnt.h
mingw32-plib.noarch: W: devel-file-in-non-devel-package
/usr/i686-pc-mingw32/sys-root/mingw/include/plib/ssgaShapes.h
mingw32-plib.noarch: W: devel-file-in-non-devel-package
/usr/i686-pc-mingw32/sys-root/mingw/lib/libplibssg.dll.a
mingw32-plib.noarch: W: spurious-executable-perm
/usr/i686-pc-mingw32/sys-root/mingw/lib/libplibssg.dll.a
mingw32-plib.noarch: W: devel-file-in-non-devel-package
/usr/i686-pc-mingw32/sys-root/mingw/include/plib/ulRTTI.h
mingw32-plib.noarch: W: devel-file-in-non-devel-package
/usr/i686-pc-mingw32/sys-root/mingw/lib/libplibul.dll.a
mingw32-plib.noarch: W: spurious-executable-perm
/usr/i686-pc-mingw32/sys-root/mingw/lib/libplibul.dll.a
mingw32-plib.noarch: W: devel-file-in-non-devel-package
/usr/i686-pc-mingw32/sys-root/mingw/lib/libplibssgaux.dll.a
mingw32-plib.noarch: W: spurious-executable-perm
/usr/i686-pc-mingw32/sys-root/mingw/lib/libplibssgaux.dll.a
mingw32-plib.noarch: W: devel-file-in-non-devel-package
/usr/i686-pc-mingw32/sys-root/mingw/include/plib/netChannel.h
mingw32-plib.noarch: W: devel-file-in-non-devel-package
/usr/i686-pc-mingw32/sys-root/mingw/include/plib/ul.h
mingw32-plib.noarch: W: devel-file-in-non-devel-package
/usr/i686-pc-mingw32/sys-root/mingw/lib/libplibpuaux.dll.a
mingw32-plib.noarch: W: spurious-executable-perm
/usr/i686-pc-mingw32/sys-root/mingw/lib/libplibpuaux.dll.a
mingw32-plib.noarch: W: devel-file-in-non-devel-package
/usr/i686-pc-mingw32/sys-root/mingw/lib/libplibpw.dll.a
mingw32-plib.noarch: W: spurious-executable-perm
/usr/i686-pc-mingw32/sys-root/mingw/lib/libplibpw.dll.a
mingw32-plib.noarch: W: devel-file-in-non-devel-package
/usr/i686-pc-mingw32/sys-root/mingw/include/plib/ssgaLensFlare.h
mingw32-plib.noarch: W: devel-file-in-non-devel-package
/usr/i686-pc-mingw32/sys-root/mingw/include/plib/ssgaParticleSystem.h
mingw32-plib.noarch: W: devel-file-in-non-devel-package
/usr/i686-pc-mingw32/sys-root/mingw/include/plib/sl.h
mingw32-plib.noarch: W: devel-file-in-non-devel-package
/usr/i686-pc-mingw32/sys-root/mingw/lib/libplibsm.dll.a
mingw32-plib.noarch: W: spurious-executable-perm
/usr/i686-pc-mingw32/sys-root/mingw/lib/libplibsm.dll.a
mingw32-plib.noarch: W: devel-file-in-non-devel-package
/usr/i686-pc-mingw32/sys-root/mingw/include/plib/js.h
mingw32-plib.noarch: W: devel-file-in-non-devel-package
/usr/i686-pc-mingw32/sys-root/mingw/include/plib/netChat.h
mingw32-plib.noarch: W: devel-file-in-non-devel-package
/usr/i686-pc-mingw32/sys-root/mingw/include/plib/puPW.h
mingw32-plib.noarch: W: devel-file-in-non-devel-package
/usr/i686-pc-mingw32/sys-root/mingw/include/plib/ssgaFire.h
mingw32-plib.noarch: W: devel-file-in-non-devel-package
/usr/i686-pc-mingw32/sys-root/mingw/include/plib/ssgMSFSPalette.h
mingw32-plib.noarch: W: devel-file-in-non-devel-package
/usr/i686-pc-mingw32/sys-root/mingw/include/plib/ssgaSphere.h
mingw32-plib.noarch: W: devel-file-in-non-devel-package
/usr/i686-pc-mingw32/sys-root/mingw/include/plib/ssgaScreenDump.h
mingw32-plib.noarch: W: devel-file-in-non-devel-package
/usr/i686-pc-mingw32/sys-root/mingw/include/plib/pcx.h
mingw32-plib.noarch: W: devel-file-in-non-devel-package
/usr/i686-pc-mingw32/sys-root/mingw/include/plib/ssgaSky.h
mingw32-plib.noarch: W: devel-file-in-non-devel-package
/usr/i686-pc-mingw32/sys-root/mingw/lib/libplibnet.dll.a
mingw32-plib.noarch: W: spurious-executable-perm
/usr/i686-pc-mingw32/sys-root/mingw/lib/libplibnet.dll.a
mingw32-plib.noarch: W: devel-file-in-non-devel-package
/usr/i686-pc-mingw32/sys-root/mingw/include/plib/slPortability.h
mingw32-plib.noarch: W: devel-file-in-non-devel-package
/usr/i686-pc-mingw32/sys-root/mingw/lib/libplibpsl.dll.a
mingw32-plib.noarch: W: spurious-executable-perm
/usr/i686-pc-mingw32/sys-root/mingw/lib/libplibpsl.dll.a
mingw32-plib.noarch: W: devel-file-in-non-devel-package
/usr/i686-pc-mingw32/sys-root/mingw/include/plib/puSDL.h
mingw32-plib.noarch: W: non-standard-dir-in-usr i686-pc-mingw32
1 packages and 0 specfiles checked; 13 errors, 67 warnings.
[petro at Workplace Desktop]$

+ The package is named according to the  Package Naming Guidelines.
+ The spec file name matches the base package %{name}, in the format
%{name}.spec.
+ The package meets the Packaging Guidelines.
+ The package is licensed with a Fedora approved license and meets the
Licensing Guidelines.
+ The License field in the package spec file matches the actual license.
+ The file, containing the text of the license(s) for the package, is included
in %doc.
+ The spec file is written in American English.
+ The spec file for the package is legible.
+ The sources used to build the package, match the upstream source, as provided
in the spec URL.

[petro at Sulaco SOURCES]$ sha256sum plib-1.8.5.tar.gz*
485b22bf6fdc0da067e34ead5e26f002b76326f6371e2ae006415dea6a380a32 
plib-1.8.5.tar.gz
485b22bf6fdc0da067e34ead5e26f002b76326f6371e2ae006415dea6a380a32 
plib-1.8.5.tar.gz.1
[petro at Sulaco SOURCES]$

+ The package successfully compiles and builds into binary rpms on at least one
primary architecture.

http://koji.fedoraproject.org/koji/taskinfo?taskID=1830025

+ All build dependencies are listed in BuildRequires.
0 No need to handle locales.
0 No need to run ldconfig for mingw32 libraries.
+ The package does NOT bundle copies of system libraries.
+ The package is not designed to be relocatable.
+ The package owns all directories that it creates.
+ The package does not list a file more than once in the spec file's %files
listings.
+ Permissions on files are set properly.
+ The package has a %clean section, which contains rm -rf %{buildroot} (or
$RPM_BUILD_ROOT).
+ The package consistently uses macros.
+ The package contains code, or permissible content.
0 No extremely large documentation files.
+ Anything, the package includes as %doc, does not affect the runtime of the
application.
0 No need to separate header files from main package for mingw32-related
package.
+ Static libraries are packaged separately.
0 No pkgconfig(.pc) files.
0 The package doesn't contain library files with a suffix (e.g. libfoo.so.1.1).
0 No need in creating devel sub-package (see note about header files above)
+ The package does NOT contain any .la libtool archives.
0 Not a GUI application.
+ The package does not own files or directories already owned by other
packages.
+ At the beginning of %install, the package runs rm -rf %{buildroot} (or
$RPM_BUILD_ROOT).
+ All filenames in rpm packages are valid UTF-8.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

More information about the Fedora-package-review mailing list