[Bug 226423] Merge Review: smartmontools

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226423





--- Comment #7 from Michal Nowak <mnowak at redhat.com>  2009-11-25 10:47:36 EDT ---
/smartmontools-5.38-24.20091119svn.fc12.i686.rpm
/home/newman/rpmbuild/RPMS/i686/smartmontools-debuginfo-5.38-24.20091119svn.fc12.i686.rpm 
smartmontools.i686: W: incoherent-init-script-name smartd ('smartmontools',
'smartmontoolsd')
3 packages and 0 specfiles checked; 0 errors, 1 warnings.

(Now installed the new smartmontools.)

newman ~ $ rpmlint smartmontools
smartmontools.i686: W: incoherent-init-script-name smartd ('smartmontools',
'smartmontoolsd')
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

I guess this is OK.

> BuildRequires:  /usr/bin/aclocal

Should be better automake.

> Source0:        http://prdownloads.sourceforge.net/%{name}/%{name}-%{version}.snap20091119.tar.gz

I don't see such file there. Just keep the filename part.
https://fedoraproject.org/wiki/Packaging/SourceURL#Using_Revision_Control

> Version:        5.38
> Release:        24.20091119svn%{?dist}
> [...]
> %setup -q -n %{name}-5.39

Shouldn't we have "Version: 5.39" + "Release: 0.20091119svn%{?dist}", since the
tarball's version is "5.39"? I'd rather call it 5.39 pre-release than 5.38
release bump.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.