[Bug 515230] Review Request: python-dmidecode - python extension module to access DMI data

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=515230





--- Comment #7 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2009-11-25 12:13:52 EDT ---
For -2:

* %define -> %global
  - I meant here:
-------------------------------------------------------------
     1  %{!?python_sitearch: %define python_sitearch %(%{__python} -c "from
distutils.sysconfig import get_python_lib; print get_python_lib(1)")}
                             ^^here^^
     2  %{!?python_ver: %define python_ver %(%{__python} -c "import sys ; print
sys.version[:3]")}
                        ^^here^^
-------------------------------------------------------------

* Tarball
(In reply to comment #6)
> First of all, I'm sorry for the mix up between the .src.rpm and the .spec file.
>  I'm not sure how that has happened.  I'm not in direct control over that web
> space, so I've posted new versions where I have full control over the files. 
> The community website will be updated again when the review is completed.

  - Well, is my recognition correct that you are explaining here why
    the source tarball changed? (by the way the tarball changed again).

* Duplicate files
  - Now build.log complains:
-------------------------------------------------------------
   157  warning: File listed twice: /usr/share/python-dmidecode/pymap.xml
-------------------------------------------------------------
    Note that %files entry:
-------------------------------------------------------------
%files
foo/
-------------------------------------------------------------
    (where foo/ is a directory) contains the directory foo/ itself and
    all files/directories/etc under foo/:
    https://fedoraproject.org/wiki/Packaging/UnownedDirectories#Unversioned

!! Requires
(In reply to comment #6)
> In regards to the "Requires" section, this contradicts the message in comment
> #1, where Jason Tibbits says: "rpm finds the delepdency on libxml2.so.2 itself;
> there's no need to specify it manually."  And now, rpmlint do give an error:
> 
> python-dmidecode.x86_64: E: explicit-lib-dependency libxml2-python
> 
> I've added it, according to your request, but I am willing to take it away if
> this is not correct.

  - Well, Jason actually said the correct thing (and it has no contradiction
with
    my comment).

    Actually
    - "Requires: libxml2" is not needed (and should be removed) because
rpmbuild
      actomatically detects library related dependency (in this case
libxml2.so.2)
      and adds such dependency into binary rpms automatically, which pulls
      libxml2 in when trying to install this package by yum.

    - However "Requires: libxml2-python" is needed because rpmbuild cannot
detect
      such python module based dependency.
      Now rpmlint throws out the error message you pointed out, because the
      package name "libxml2-python" contains "lib" string.
      However "this one (rpmlint) is bogus; ignore it." (as Jason said).


> * Parallel make
> I've looked into this.  As the building is done via python setup.py/Distutil, I
> don't see any possibility to support parallel building.  Therefore, I find it
> rather misleading adding %{_smp_mflags} to the make command.  I hope you don't
> mind me that I have not modified this.
  + Okay.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.