[Bug 231861] Merge Review: cyrus-imapd - high-performance mail server (IMAP, POP3, ...)

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=231861





--- Comment #16 from Mads Kiilerich <mads at kiilerich.com>  2009-11-25 20:30:31 EDT ---
Ok, another round of comments/questions:

MIT license? AFAICS the COPYRIGHT file is BSD. The CMU entry on
http://fedoraproject.org/wiki/Licensing is internally inconsistent, and
http://fedoraproject.org/wiki/Licensing/MIT#CMU_Style isn't the cyrus license -
AFAIK that license has never applied to cyrus.

_cyrusconf seems like a bit of overkill.

Haven't all the versions in the requirements been irrelevant for ages?

Shouldn't most of the renamings and other file hackings in %build be in %prep?

Why this "if pkg-config openssl" thing? When and why does it apply?

pushd before "perl -pi" and use of "$(ls *x)" isn't needed - I would prefer the
simple version

It seems like there is no need for cleanup of "*~" and "*.html.*".

Why do %pre stop the service but pretend it is running?

Is the chattr in %post OK? It might be a good idea, but is it OK that a package
does it automatically? Shouldn't it be in README.RPM instead? Anyway, why not
just
chattr -R +S %{_var}/lib/imap/{user,quota} %{_var}/spool/imap

Shouldn't the certificate creation be moved to service start where it is more
transparent what goes on, just like /etc/rc.d/init.d/sshd does?

Why is the user and group (and csync) created by the utils package %pre which
doesn't use them? Move to main package?

Wouldn't it be better if csync were included in the setup packages
/etc/services?

Is it relevant to include html versions of the man pages?

Much of README.RPM is outdated or irrelevant. I think "chkconfig cyrus-imapd
on" should be mentioned. README.buildoptions doesn't exist. And postfix
shouldn't be discriminated ;-)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.