[Bug 539486] Review Request: perl-Data-AsObject - Easy OO access to complex perl data structures

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=539486


Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #2 from Parag AN(पराग) <panemade at gmail.com>  2009-11-26 01:07:25 EDT ---
Review:
+ package builds in mock (rawhide i686).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1824122
- rpmlint output for SRPM and for RPM.
perl-Data-AsObject.noarch: W: wrong-file-end-of-line-encoding
/usr/share/doc/perl-Data-AsObject-0.05/Changes
perl-Data-AsObject.noarch: W: wrong-file-end-of-line-encoding
/usr/share/doc/perl-Data-AsObject-0.05/README
==> Fix this

+ source files match upstream url (sha1sum)
9dcabb784c07512611dc4d033fc2652d027c0a2d  Data-AsObject-0.05.tar.gz

+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=2, Tests=13,  0 wallclock secs ( 0.03 usr  0.00 sys +  0.10 cusr  0.00
csys =  0.13 CPU)
+ Package perl-Data-AsObject-0.05-1.fc13.noarch =>
Provides: perl(Data::AsObject) = 0.05 perl(Data::AsObject::Array)
perl(Data::AsObject::Hash)
Requires: perl(Carp) perl(Data::AsObject) perl(Data::AsObject::Array)
perl(Data::AsObject::Hash) perl(Scalar::Util) perl(base) perl(strict)
perl(warnings)
+ Not a GUI application

Suggestions:
1) you can fix rpmlint warnings by adding following lines to %prep section of
spec
sed -i 's/\r//' Changes README

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.