[Bug 225286] Merge Review: aspell

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=225286





--- Comment #17 from Ivana Varekova <varekova at redhat.com>  2009-11-27 06:16:13 EDT ---
Hello, thanks for the comments, they are incorporated in aspell-0.60.6-8.fc13
in the last version I move aspell-import to documentation part (in the previous
version aspell-import have not executable bit and nobody wants the rights back
so I think the better solution is ot put it to the documentation).


(In reply to comment #15)
> I would even prefer a yet more radical splitting:
> 
> * a -lib package with content of /usr/lib/aspell-0.60, the libs and
>   the .mo files
> 
> * move the precat, preunzip, prezip, prezip-bin and word-list-compress
>   binaries either into -devel (afais, they are only used to create
>   dictionaries), or into a new -utils subpackage
> 
> * move 'aspell-import' into -utils
> 
> * keep aspell, ispell, run-with-aspell, spell and related man pages in
>   main package. 'aspell' adds a ncurses dep which is not needed by
>   -libs
> 
> * at first glance, 'aspell.info' contains end user information only
>   and should stay in main and does not need to be moved into -lib
For me the current system seems to be good enough (aspell-import is in
documentation section - but nobody wants it)


> Other issues:
> 
> * remove the explicit 'Requires: aspell-en'; I am pretty sure that my
>   mom will never have use for the english dictionary but uses the
>   german one only

fixed

> * are all the 'Conflicts:' really required for a recent system?
thanks, removed

> * the
>   | Provides: pspell < 0.13
>   | Obsoletes: pspell < 0.13
thanks, removed

>   does not seem to make sense; either write 'Provides: pspell = 0.13',
>   or remove it completely. Ditto for -devel
> 
> * the
> 
>   | Requires(pre): /sbin/install-info
> 
>   is wrong and should be 'Requires(post)'
thanks, fixed

> * /sbin/ldconfig MUST be required
the dependency is automatically added - so no need to be there

> * afair, there was a rule, that Summary: must not begin with 'A'.
thanks, fixed

> * the 'exit 0' in the scriptlets does not make sense
thanks, fixed


Add #16 
| exec "$@"
is bogus - try e.g. exec "echo hello".

Is the package ok now?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.