[Bug 226192] Merge Review: net-snmp

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226192


Jan Safranek <jsafrane at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|needinfo?                   |




--- Comment #6 from Jan Safranek <jsafrane at redhat.com>  2009-11-27 08:58:53 EDT ---
Huh, the review is still open... I should have noticed it earlier. It has been
quite long time since the review has started and now the net-snmp package looks
differently and hopefuly simpler.

I have just fixed the errors noted above and prepared net-snmp-5.5-3.fc13 in
rawhide, which should be review-able again.

X build root is not correct.
Fixed

? license field matches the actual license.
Fixed (BSD and MIT)

? %check is not present but there seems to be a test suite.
I've added the %check. I am not sure it will work when the package is compiled
on system with net-snmp already installed. It works in mock and in koji though.
The whole %check is not executed when %{netsnmp_check} == 0 to speed up my
local builds.

X file permissions are appropriate.
rpmlint still complains about executable flag on agent/helpers/table_row.c,
I have fixed it upstream, see
http://net-snmp.svn.sourceforge.net/viewvc/net-snmp?view=rev&revision=17839 . I
hope it's enough - I don't want to add another .spec voodoo just because of
this one file.

X scriptlets present without proper dependencies.
Fixed

X rpmlint has many valid complaints.
Fixed most of them, following remain:
net-snmp.i686: W: dangerous-command-in-%post mv
net-snmp.x86_64: W: dangerous-command-in-%post mv
There is one mv, which moves net-snmp data from /var/net-snmp to
/var/lib/net-snmp, IMHO it's valid usage.

net-snmp.src: W: strange-permission net-snmp-config 0755
net-snmp.src: W: strange-permission net-snmpd.init 0755
net-snmp.src: W: strange-permission net-snmptrapd.init 0755
These files are stored in CVS with executable bit set, AFAIK there is no easy
way how to remove it. And IMHO it's pretty harmless.

net-snmp.src: W: %ifarch-applied-patch Patch1: net-snmp-5.4.1-pie.patch
IA64 has some problems with -pie, I'll look into it. Maybe it's not needed
anymore - is IA64 secondary architecture?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.