[Bug 541154] Review Request: xfce4-volumed - Daemon to add additional functionality to the volume keys of the keyboard

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=541154


Kevin Fenzi <kevin at tummy.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #2 from Kevin Fenzi <kevin at tummy.com>  2009-11-28 00:57:48 EDT ---
OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name. 
OK - Spec has consistant macro usage. 
OK - Meets Packaging Guidelines. 
OK - License (GPLv3+)
OK - License field in spec matches
OK - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
9f95a7e002c3c165733e19b70de22c6b  xfce4-volumed-0.1.8.tar.bz2
9f95a7e002c3c165733e19b70de22c6b  xfce4-volumed-0.1.8.tar.bz2.orig
OK - BuildRequires correct
OK - Package has %defattr and permissions on files is good. 
OK - Package has a correct %clean section. 
OK - Package has correct buildroot
OK - Package is code or permissible content. 
OK - Packages %doc files don't affect runtime. 
OK - Package has rm -rf RPM_BUILD_ROOT at top of %install

OK - Package is a GUI app and has a .desktop file

OK - Package compiles and builds on at least one arch. 
OK - Package has no duplicate files in %files. 
OK - Package doesn't own any directories other packages own. 
OK - Package owns all the directories it creates. 
OK - Package obey's FHS standard (except for 2 exceptions)
See below - No rpmlint output. 
OK - final provides and requires are sane.

SHOULD Items:

OK - Should build in mock. 
OK - Should build on all supported archs
OK - Should function as described. 
OK - Should have dist tag
OK - Should package latest version
OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or
/usr/sbin

Issues: 

1. rpmlint says: 

xfce4-volumed.i586: W: spelling-error-in-description en_US xfce
xfce4-volumed.src: W: spelling-error-in-description en_US xfce
xfce4-volumed-debuginfo.i586: W: spelling-error-in-summary en_US xfce
xfce4-volumed-debuginfo.i586: W: spelling-error-in-description en_US xfce

Doublecheck the spelling in summary and description. 

xfce4-volumed.i586: W: conffile-without-noreplace-flag
/etc/xdg/autostart/xfce4-volumed.desktop

Can be ignored I think. 

I don't see any blockers, just run the summary and description through a 
spell checker before you import. ;) 

This package is APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.