[Bug 521909] Review Request: ne7ssh - SSH Library is a Secure Shell client software written in C++

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=521909





--- Comment #19 from Pavel Alexeev (aka Pahan-Hubbitus) <pahan at hubbitus.info>  2009-10-01 15:27:40 EDT ---
(In reply to comment #18)
> Splitting-hairs. You *could* include these tiny example source files in the
> -devel package, but it really doesn't matter. It's cleaner to treat them as
> documentation.
If we treat this as documentation it should be included in -doc.
What is a big problem set nw7ssh-devel as dependency for nw7ssh-doc?

> * The examples don't even build from scratch. They fail. You haven't tried to
> compile them at all, which shows how unimportant they are to you. Most of them
> are missing to include the cstdio header.
You are wrong. I try build it. I can say more - I start learning this library
by examples (as many do, it is why I pay such attention for that). But you a
right, there is cstdio header issue. As I mail about it to upstream author in
main library. This is trivial to fix errors. So, I hope it will be fixed soon.
Or you think I should expand my patch on examples too?

> * The examples won't build inside their directory as only superuser root can
> write to that directory. A normal user would need to copy them somewhere else.
Yes. I known. But user can copy example "as is" and build it.

> * The examples don't even work if built without modifications, since some
> contain only examplary values instead of real-life configuration values. They
> are really just an add-on to the API documentation, not ready-to-run demos.
Modifications needed only dfor user/password. Other work fine with included
Makefile. Furthermore, examples built ok (except cstdio header issue) it only
may not functional properly (but user/pass is extremal private values to
provide "commons").

> * Documentation packages also need a program that can display the
> documentation. For example, a browser for HTML pages. Or a viewer for PDF
> files. Such requirements are _not_ hardcoded as package dependencies.
No special tools needed. Standard cat, more or less commands may act as
documentation reader. Especially for C-files. It is generic, it is not required
listed as dependencies.

> * All -devel packages need a matching development environment, i.e. compilers
> and tools, standard libraries. Such requirements are _not_ hardcoded as package
> dependencies either.
Off course. But -devel packages itself must be listed as dependencies.

> 
> * A packaging issue is left, too.
>   This is Fedora's cmake invocation with the %{cmake} macro:
> 
>  %build
> -CFLAGS="%{optflags}" CXXFLAGS="%{optflags}" cmake .
> +%{cmake} .
>  make all %{?_smp_mflags}
> 
> Look at "rpm --eval %cmake" to see what it does. Not only does it set the
> optflags, it also increases verbosity to fill the build log with relevant
> output.  
This is very helpful hint. Thank you. I've fixed it.

http://hubbitus.net.ru/rpm/Fedora11/ne7ssh/ne7ssh.spec

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.