[Bug 521909] Review Request: ne7ssh - SSH Library is a Secure Shell client software written in C++

bugzilla at redhat.com bugzilla at redhat.com
Fri Oct 2 08:06:47 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=521909





--- Comment #24 from Pavel Alexeev (aka Pahan-Hubbitus) <pahan at hubbitus.info>  2009-10-02 04:06:46 EDT ---
(In reply to comment #23)
> We're going in circles...
> 
> As pointed out before, source code examples are technical documentation. The
> guidelines are explicit on where to put "API Documentation":
> 
>   https://fedoraproject.org/wiki/Packaging:Guidelines#Documentation
> 
> Nothing wrong with putting them into the -devel package as %doc examples. It's
> the right place for them.
Cite from this link: "Pay also attention about which subpackage you include
documentation in, for example API documentation belongs in the -devel
subpackage, not the main one. Or if there's a lot of documentation, consider
putting it into a subpackage. In this case, it is recommended to use *-doc as
the subpackage name, and Documentation as the value of the Group tag."
So, I think we must threat it as "documentation in -devel OR -doc" (as I make
decision what it is big and create this sub-package), not in both!

> Except that they still lack <cstdio> and fail to
> compile. ;)
Well, I extend patch to examples too.

> No, that doesn't apply to documentation. More often than not, in documentation
> we explicitly get rid of superfluous dependencies. For example: Perl scripts
> included as %doc. Typically, these are explicitly made non-executable, so
> rpmbuild's dependency generator does not add any Perl Module dependencies
> automatically.  
Yes, I known rpmlint have this check check -
http://rpmlint.zarb.org/cgi-bin/trac.cgi/browser/trunk/DocFilesCheck.py#L88

Please run command:
$ repoquery '*-doc' --requires
and you can see ho many -doc subpackages have dependencies. There perl, perl
modules, -devel packages and just many other programs. Off course some of that
is errors, but I do not see any trouble have such dependency when it can have
worth.

http://hubbitus.net.ru/rpm/Fedora11/ne7ssh/ne7ssh-1.3.1-6.fc11.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list