[Bug 526651] Review Request: xpaint - An X Window System image editing or paint program

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=526651


Thomas Janssen <thomasj at fedoraproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |thomasj at fedoraproject.org




--- Comment #3 from Thomas Janssen <thomasj at fedoraproject.org>  2009-10-03 04:40:53 EDT ---
Ok, i cant get the source from that URL in the spec, 404 is given. There's not
even a downloadlink on the page that comes up with the URL: from the spec.

A page with a downloadlink comes up with: 
https://sourceforge.net/projects/sf-xpaint

A working downloadlink is:
http://downloads.sourceforge.net/project/sf-xpaint/sf-xpaint/%{name}-%{version}/%{name}-%{version}.tar.bz2

MUST: rpmlint must be run on every package. The output should be posted in the
review.

Where did you find the MIT license? There's no license file in the tarball and
the project homepage says: License: "Other license" which is a link to a page
with other projects.

MUST: The package must be licensed with a Fedora approved license and meet the
http://fedoraproject.org/wiki/Packaging/LicensingGuidelines
MUST: The License field in the package spec file must match the actual license.

Upstream has released 2.8.3 by the way.

MUST: The package MUST successfully compile and build into binary rpms on at
least one primary architecture.

Can you post the 'Task Info' link to a koji scratch build here, thanks.

Icon tag in Desktop Files, the icon tag can be specified in two ways:
Full path to specific icon file or shortname without file extension.

You use shortname with file extension.

Missing: BuildRequires: desktop-file-utils

desktop-file-install MUST be used if the package does not install the file or
there are changes desired to the .desktop file (such as add/removing
categories, etc).
http://fedoraproject.org/wiki/Packaging/Guidelines#desktop

-- 
Fedora Bugzappers volunteer triage team
https://fedoraproject.org/wiki/BugZappers

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.