[Bug 526866] Review Request: torium - A minimalistic, easily configurable torrent client for Linux

bugzilla at redhat.com bugzilla at redhat.com
Sat Oct 3 09:53:17 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=526866


Christoph Wickert <cwickert at fedoraproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #5 from Christoph Wickert <cwickert at fedoraproject.org>  2009-10-03 05:53:16 EDT ---
Really? I can't see a reverence to gconf in the code.

Anyway:
OK - macro usage consistent
OK - torium.desktop is fine
OK - timestamp of Source0 matches

One last thing: Please Add
INSTALL='install -p' to make install to preserve the time stamps of the flags.
It didn't matter before, because all files were generated or changed during
build, but for static data like the flags the timestamps should be preserved.

Not a blocker, change it later, the package is APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list