[Bug 525211] Review Request: rubygem-ditz - A command-line issue tracker

bugzilla at redhat.com bugzilla at redhat.com
Sat Oct 3 18:26:49 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=525211





--- Comment #11 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2009-10-03 14:26:48 EDT ---
For -3:

* License
  - Well, actually it should be "GPLv3+ with exceptions", sorry.

* Local copy of system-wide files
  - As rubygem-trollop is packaged seperately, this package
    should not include %geminstdir/lib/trollop.rb .

* %files entry consideration
  - As ditz script is installed under %_bindir (as symlink),
    it is better that the corresponding man file is moved
    to %_mandir/man1 (currently under %geminstdir/man)

  - "INSTALL" file is probably not needed (this type of files
    are usually needed for people to install a software by
    themselves and not needed for people using rpm)

  - "Changelog" "LICENSE" and so on should correctly be
    marked as %doc.

About using virtual Provides:
- This is not specific to ruby or perl. Using virtual Provides
  for (Build)Requires is recommended in many cases, because this
  usage is one of the reasons we add virtual Provides.
  For example:
  - We use "BR: libGL-devel" instead of "BR: mesa-libGL-devel"
  - We use "R: tex(latex)" instead of "R: texlive-latex"

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list