[Bug 523650] Review Request: qmpdclient - A Qt4 based MPD client

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=523650


Thomas Janssen <thomasj at fedoraproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |thomasj at fedoraproject.org




--- Comment #16 from Thomas Janssen <thomasj at fedoraproject.org>  2009-10-03 16:19:13 EDT ---
A few quick comments:

License is GPLv2+
(Look at the source code "either version 2 of the License, or (at your option)
any later version.")

There's no need to include BR: gcc-c++
That's part of the minimal build environment:
http://fedoraproject.org/wiki/Packaging/Guidelines#BuildRequires

MUST: Each package must consistently use macros.
Source0: http://files.4-web.net/%{name}/%{name}-%{release}.tar.gz
Source1: %{name}.desktop 
why do you use capital letters there?
Patch: %{name}.pro.patch

What's with the patch anyways? You have it there but dont use it.
You could comment it. But that's up to you.

Be consistent: %{_datadir} %_datadir

%doc is empty, fill it with AUTHOR COPYING INSTALL README

MUST: rpmlint must be run on every package. The output should be posted in the
review.
Please post it here.

Please post as well the "Task Info link" of a koji scratch build here:
http://fedoraproject.org/wiki/PackageMaintainers/Join

-- 
Fedora Bugzappers volunteer triage team
https://fedoraproject.org/wiki/BugZappers

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.