[Bug 528125] Review Request: MySQL-zrm - MySQL backup manager

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=528125


Lubomir Rintel <lkundrak at v3.sk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |lkundrak at v3.sk
         AssignedTo|nobody at fedoraproject.org    |lkundrak at v3.sk
               Flag|                            |fedora-review?




--- Comment #2 from Lubomir Rintel <lkundrak at v3.sk>  2009-10-09 06:37:18 EDT ---
1.) Please do not repeat %attr-s, use %defattr instead, such as
%defattr(0644,root,root,0755)

2.) Don't duplicate RPM's work when installing documentation.
Replace

cp -rp usr/share/doc/*    %{buildroot}/%{_defaultdocdir}/
...
%attr(644,root,root) %doc %{_defaultdocdir}/*/*

with something like "%doc usr/share/doc/*"

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.