[Bug 527971] Review Request: ocaml-react - OCaml framework for Functional Reactive Programming (FRP)

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=527971


William Cohen <wcohen at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review+




--- Comment #5 from William Cohen <wcohen at redhat.com>  2009-10-09 12:06:33 EDT ---
$ rpmlint ../RPMS/x86_64/ocaml-react-*
2 packages and 0 specfiles checked; 0 errors, 0 warnings.

$ rpmlint ocaml-react.spec 
0 packages and 1 specfiles checked; 0 errors, 0 warnings.

+ package name satisfies the packaging naming guidelines
+ specfile name matches the package base name
+ package should satisfy packaging guidelines
+ license meets guidelines and is acceptable to Fedora BSD
+ license matches the actual package license
+ %doc includes license file
+ spec file written in American English
+ spec file is legible
+ upstream sources match sources in the srpm
+ package successfully builds on at least one architecture
  x86_64, i686
n/a ExcludeArch bugs filed
+ BuildRequires list all build dependencies
  http://koji.fedoraproject.org/koji/taskinfo?taskID=1735265
n/a %find_lang instead of %{_datadir}/locale/*
n/a binary RPM with shared library files must call ldconfig in %post and
%postun
+ does not use Prefix: /usr
+ package owns all directories it creates
+ no duplicate files in %files
+ %defattr line
+ %clean contains rm -rf $RPM_BUILD_ROOT
+ consistent use of macros
+ package must contain code or permissible content
n/a large documentation files should go in -doc subpackage
+ files marked %doc should not affect package
+ header files should be in -devel
n/a static libraries should be in -static
n/a packages containing pkgconfig (.pc) files need 'Requires: pkgconfig'
n/a libfoo.so must go in -devel
+ -devel must require the fully versioned base
+ packages should not contain libtool .la files
n/a packages containing GUI apps must include %{name}.desktop file
+ packages must not own files or directories owned by other packages
+ %install must start with rm -rf %{buildroot} etc.
+ filenames must be valid UTF-8
+ use %global instead of %define

Optional:

+ if there is no license file, packager should query upstream
  The LICENSE is a separate SOURCE1 file and not in SOURCE0.
  On http://erratique.ch/software/react:
     React is made of a single, independent, module and distributed under
    the new BSD license.
n/a translations of description and summary for non-English languages, if
available
+ reviewer should build the package in mock
  scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1735265
+ the package should build into binary RPMs on all supported architectures
+ review should test the package functions as described
+ scriptlets should be sane
n/a pkgconfig files should go in -devel
+ shouldn't have file dependencies outside /etc /bin /sbin /usr/bin or
  /usr/sbin

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.