[Bug 525759] Review Request: qtcurve-kde4 - A set of widget styles for Qt4/KDE4 based apps

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=525759


Rex Dieter <rdieter at math.unl.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rdieter at math.unl.edu




--- Comment #3 from Rex Dieter <rdieter at math.unl.edu>  2009-10-12 13:08:08 EDT ---
A few comments:

1.  %files, use instead:
%{_kde4_appsdir}/QtCurve/
else that dir is unowned

2.  %post/%postun scriptlets aren't needed (no shlibs here)

3.  use of sed in %prep
I'd prefer (upstreamable) patches here, but we don't need to consider that a
blocker for now.  we can sort that out later.

4.  can drop extraneous
BR: qt-devel


We noticed in #fedora-kde today in testing this, that the windeco is a bit
borked, please notify upstream.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.