[Bug 526115] Review Request: qtcurve-gtk2 - A set of widget styles for Gtk2 based apps

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=526115





--- Comment #2 from Thomas Janssen <thomasj at fedoraproject.org>  2009-10-13 07:34:09 EDT ---
(In reply to comment #1)
> A few comments:
> 
> 1.  can drop extranenous
> BuildRequires: qt-devel

Done

> 2.  drop
> Requires: qtcurve-kde4...
> (agreed on irc)

Done

> 3.  description:
> allowing users to achieve a uniform look between three widget toolkits.
> "three"?  maybe meant to say "these"  here. ?

Yeah, my bad. There are three if one includes -kde3 i guess (description taken
from upstream). Since i'm not building it AND it sounds even better, i changed
to "these".

> 4.  %post/%postun scriplets not needed

Done.

> 5.  %files , instead use:
> %{_libdir}/gtk-2.0/*/engines/libqtcurve.so
> %{_datadir}/themes/QtCurve/
> 
> no need for _kde4 macros here, and to own QtCurve/ dir  

Done

[thomas at tusdell ~]$ rpmlint rpmbuild/SPECS/qtcurve-gtk2.spec
rpmbuild/SRPMS/qtcurve-gtk2-0.69.0-1.fc10.src.rpm
rpmbuild/RPMS/x86_64/qtcurve-gtk2-*69*
3 packages and 1 specfiles checked; 0 errors, 0 warnings.

http://koji.fedoraproject.org/koji/taskinfo?taskID=1743212

Spec URL: http://thomasj.fedorapeople.org/reviews/qtcurve-gtk2.spec
SRPM URL:
http://thomasj.fedorapeople.org/reviews/qtcurve-gtk2-0.69.0-1.fc10.src.rpm

-- 
Fedora Bugzappers volunteer triage team
https://fedoraproject.org/wiki/BugZappers

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.