[Bug 528841] Review Request: sks - Synchronizing Key Server

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=528841


Todd Zullinger <tmz at pobox.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tmz at pobox.com




--- Comment #1 from Todd Zullinger <tmz at pobox.com>  2009-10-13 23:37:03 EDT ---
> %__make install PREFIX="%{buildroot}/usr" MANDIR="%{buildroot}/usr/share/man"

This line should use macros for /usr and /usr/share/man, e.g.:

%__make install PREFIX="%{buildroot}%{_bindir}" MANDIR="%{buildroot}%{_mandir}"

> %files
> %defattr(-,root,root)
> #%doc AUTHORS LICENSE LICENSE.OpenSSL README znc.conf

This commented line ...

> %doc BUGS CHANGELOG COPYING FILES README TODO VERSION
> %{_bindir}/sks
> %{_bindir}/sks_build.sh
> %{_bindir}/sks_add_mail
> %{_mandir}/man8/sks.8.gz
> #%{_mandir}/man1/*
> #%{_libdir}/znc/
> #%{_datadir}/znc/

And these three commented lines should be removed.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.